Latest&Greatest gradle in 1.6.11

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Latest&Greatest gradle in 1.6.11

Felix Natter
hello Dimitry,

I tried to test this patch as discussed [1]:

diff --git a/freeplane_framework/script/freeplane.sh b/freeplane_framework/script/freeplane.sh
index a9e3e4e80..795bbe157 100755
--- a/freeplane_framework/script/freeplane.sh
+++ b/freeplane_framework/script/freeplane.sh
@@ -165,6 +165,10 @@ if [ "${JAVA_TYPE}" != "sun" ]; then
   # OpenJDK(7) fixes (don't use OpenJDK6!!)
   JAVA_OPTS="-Dgnu.java.awt.peer.gtk.Graphics=Graphics2D $JAVA_OPTS"
 
+  # this fixes font rendering for some people, see:
+  # http://www.freeplane.org/wiki/index.php/Rendering_Issues
+  JAVA_OPTS="-Dawt.useSystemAAFontSettings=on -Dswing.aatext=true $JAVA_OPTS"
+
   # this sometimes helps with visual mindmap distortions
   # (but it can also create trouble so it's disabled by default):
   #JAVA_OPTS="-Dsun.java2d.xrender=True $JAVA_OPTS"

[1] https://github.com/freeplane/freeplane/issues/82

However, your dependency cleanup commit:
https://github.com/freeplane/freeplane/commit/df7a060f2473a0fcec3a26a049e11ac14fc14ec2#diff-c197962302397baf3a4cc36463dce5ea

does not work with gradle 3.2.1:

* Where:
Build file '/home/felix/git2/freeplane2/build.gradle' line: 141

* What went wrong:
A problem occurred evaluating root project 'freeplane2'.
> Could not get unknown property 'runtimeClasspath' for configuration
> container.
[...]

My hypothesis is that
project.configurations.runtime->project.configurations.runtimeClasspath
only works with gradle 4.x.

This means that:
- all contributors will need to install gradle 4.x; this is doable, as
  you can download and unzip a binary distribution with java>=7.

- I might be able to package this for Debian if I undo this patch,
  but then the package might not work correctly?
  (other distros will probably have similar problems)
  It could take years until gradle 4.x is packaged for Debian/other
  distros.

So I leave it up to you, how you want to treat this commit in 1.6.11.
Does anyone else here have an opinion regarding this?

Cheers and Best Regards,
--
Felix Natter
Reply | Threaded
Open this post in threaded view
|

Re: Latest&Greatest gradle in 1.6.11

Dimitry Polivaev
Administrator
> However, your dependency cleanup commit:
> https://github.com/freeplane/freeplane/commit/df7a060f2473a0fcec3a26a049e11ac14fc14ec2#diff-c197962302397baf3a4cc36463dce5ea
>
> does not work with gradle 3.2.1:

I changed it, please pull and try again.

Regards,
Dimitry


Reply | Threaded
Open this post in threaded view
|

Re: Latest&Greatest gradle in 1.6.11

Felix Natter
"Dimitry Polivaev [via Freeplane Developer]"
<[hidden email]> writes:

>> However, your dependency cleanup commit:
>> https://github.com/freeplane/freeplane/commit/df7a060f2473a0fcec3a26a049e11ac14fc14ec2#diff-c197962302397baf3a4cc36463dce5ea
>>
>> does not work with gradle 3.2.1:
>
> I changed it, please pull and try again.

Thanks, now it builds with gradle 3.2.1.

I have fixed OpenJDK detection (I think previously, non-OpenJDKs were
detected as OpenJDKs and vice versa) and added the workaround for
OpenJDKs.

Cheers and Best Regards,
--
Felix Natter
debian/rules!